fix: address code review findings

- Fix notifications_sent PK: changed from (rgid, sent_at) to rgid-only PK
  to prevent duplicate RGID rows across seconds. Use INSERT OR REPLACE
  instead of INSERT OR IGNORE for true idempotency.
- Add foreign key constraints to DDL (artist_id references artist_settings,
  rgid references external_releases) per specification.
- Enable PRAGMA foreign_keys=ON and PRAGMA busy_timeout=5000 for concurrent
  access safety.
- Fix GetNotificationSentAt query: add ORDER BY sent_at DESC LIMIT 1 for
  deterministic results.
- Fix config test: change YAML key from 'chat' to 'chat_id' to match struct
  tag, add ChatID assertion.
- Fix migration tracking test: correct error message from "expected 4" to
  "expected 3".
- Remove dead code in TestLoadConfig_InvalidPort: eliminate unused YAML
  template and remove port 0 case (valid, not invalid).
- Remove unused path parameter from buildConfigWithPort helper.
- Remove pointless 100ms sleep in run() and unused time import.
- Remove tautological TestDefaultConfigPath test.
- Update README.md: Go version 1.21+ to 1.25+, placeholder passwords to
  CHANGE_ME.
- Update config.yaml.example: placeholder passwords to CHANGE_ME.
- Update all database tests to insert parent rows first for FK satisfaction.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

This commit is contained in:

Vladimir Zagainov

2026-05-20 11:07:28 +03:00

parent fb74b5fbba

commit 47d4ec4e32

11 changed files with 273 additions and 49 deletions

4

config.yaml.example

View File

@@ -3,12 +3,12 @@ server:
   port: 8080
   # Basic Auth for Web UI access
   username: "admin"
   password: "password123"
   password: "CHANGE_ME"
 navidrome:
   url: "http://localhost:4533"
   user: "watcher_service"
   password: "user_password"
   password: "CHANGE_ME"
 musicbrainz:
   user_agent: "NaviWatcher/1.0 ( your-email@example.com )"

fix: address code review findings

4 config.yaml.example Unescape Escape View File

4

config.yaml.example

View File