Mrixs/NaviWatcher
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: complete task 6 - fix stale notification pruning to avoid SQLite parameter limit

Browse Source
This commit is contained in:
Vladimir Zagainov
2026-07-26 11:24:40 +03:00
parent 355a12c6a6
commit 4b4e852fd1
3 changed files with 162 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
docs/plans/2026-07-21-fix-review-findings.md
View File

@@ -63,18 +63,17 @@ Problem: Three separate filter implementations (`musicbrainz.FilterReleaseGroups
- [x] Run tests - must pass before task 5
### Task 5: Fix ArtistCacheFresh lexicographic time comparison
- [ ] Change `external_releases.cached_at` from TEXT to INTEGER (unix epoch seconds) via migration `006_cached_at_to_integer`
- [ ] Update `FormatCachedAt` to return `time.Time.Unix()` (int64)
- [ ] Update `ArtistCacheFresh` query to compare `cached_at >= ?` as integers
- [ ] Update `SaveExternalRelease` and sync insert to store integer timestamp
- [ ] Write tests: verify cache freshness check works across format change; test migration on existing DB
- [ ] Run tests - must pass before task 6
- [x] Change `external_releases.cached_at` from TEXT to INTEGER (unix epoch seconds) via migration `010_cached_at_to_integer`
- [x] Update `FormatCachedAt` to return `time.Time.Unix()` (int64)
- [x] Update `ArtistCacheFresh` query to compare `cached_at >= ?` as integers
- [x] Update `SaveExternalRelease` and sync insert to store integer timestamp
- [x] Write tests: verify cache freshness check works across format change; test migration on existing DB
- [x] Run tests - must pass before task 6
### Task 6: Batch stale notification pruning to avoid SQLite parameter limit
- [ ] Modify stale notification deletion in `sync.go` (lines 150-185) to process in chunks of 500 parameters
- [ ] Or rewrite using CTE: `DELETE FROM notifications_sent WHERE rgid IN (SELECT rgid FROM external_releases WHERE artist_id = ? AND rgid NOT IN (SELECT rgid FROM external_releases WHERE artist_id = ? AND rgid IN (...)))` — but CTE still needs placeholders. Safer: batch loop over `synced` slice in chunks of 900.
- [ ] Write test with >1000 synthetic release groups to verify no parameter-limit error
- [ ] Run tests - must pass before task 7
- [x] Modify stale notification deletion in `sync.go` (lines 150-185) to process in chunks of 500 parameters
- [x] Write test with >1000 synthetic release groups to verify no parameter-limit error
- [x] Run tests - must pass before task 7
### Task 7: Handle ErrArtistNotFound in ScanArtist gracefully
- [ ] In `ScanArtist`, wrap `GetArtistSettings` call; if `ErrArtistNotFound`, use empty `TypeFilter` (no filtering) instead of returning error