feat: add CRUD operations for notifications_sent table
Implement MarkNotificationSent, IsNotificationSent, and GetUnnotifiedReleases with LEFT JOIN query. Includes 10 table-driven tests covering success, error, idempotent, and edge cases. Also go fmt cleanup on existing files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
265
internal/database/notifications_test.go
Normal file
265
internal/database/notifications_test.go
Normal file
@@ -0,0 +1,265 @@
|
||||
package database
|
||||
|
||||
import (
|
||||
"database/sql"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// TestMarkNotificationSent_New verifies inserting a new notification record.
|
||||
func TestMarkNotificationSent_New(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
if err := MarkNotificationSent(db, "rgid-1"); err != nil {
|
||||
t.Fatalf("MarkNotificationSent() error: %v", err)
|
||||
}
|
||||
|
||||
sentAt, err := GetNotificationSentAt(db, "rgid-1")
|
||||
if err != nil {
|
||||
t.Fatalf("GetNotificationSentAt() error: %v", err)
|
||||
}
|
||||
if sentAt == "" {
|
||||
t.Error("expected sent_at to be non-empty")
|
||||
}
|
||||
}
|
||||
|
||||
// TestMarkNotificationSent_Idempotent verifies that marking the same RGID twice does not fail.
|
||||
func TestMarkNotificationSent_Idempotent(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
if err := MarkNotificationSent(db, "rgid-1"); err != nil {
|
||||
t.Fatalf("first MarkNotificationSent() error: %v", err)
|
||||
}
|
||||
if err := MarkNotificationSent(db, "rgid-1"); err != nil {
|
||||
t.Fatalf("second MarkNotificationSent() error: %v", err)
|
||||
}
|
||||
|
||||
// Should still have exactly one row.
|
||||
var count int
|
||||
err = db.Conn().QueryRow("SELECT COUNT(*) FROM notifications_sent WHERE rgid = ?", "rgid-1").Scan(&count)
|
||||
if err != nil {
|
||||
t.Fatalf("count query error: %v", err)
|
||||
}
|
||||
if count != 1 {
|
||||
t.Errorf("expected 1 notification row, got %d", count)
|
||||
}
|
||||
}
|
||||
|
||||
// TestIsNotificationSent_True verifies true for a sent notification.
|
||||
func TestIsNotificationSent_True(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
if err := MarkNotificationSent(db, "rgid-1"); err != nil {
|
||||
t.Fatalf("MarkNotificationSent() error: %v", err)
|
||||
}
|
||||
|
||||
sent, err := IsNotificationSent(db, "rgid-1")
|
||||
if err != nil {
|
||||
t.Fatalf("IsNotificationSent() error: %v", err)
|
||||
}
|
||||
if !sent {
|
||||
t.Error("expected IsNotificationSent to return true")
|
||||
}
|
||||
}
|
||||
|
||||
// TestIsNotificationSent_False verifies false for an unsent RGID.
|
||||
func TestIsNotificationSent_False(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
sent, err := IsNotificationSent(db, "nonexistent")
|
||||
if err != nil {
|
||||
t.Fatalf("IsNotificationSent() error: %v", err)
|
||||
}
|
||||
if sent {
|
||||
t.Error("expected IsNotificationSent to return false for nonexistent RGID")
|
||||
}
|
||||
}
|
||||
|
||||
// TestGetNotificationSentAt_NotFound verifies sql.ErrNoRows for unsent RGID.
|
||||
func TestGetNotificationSentAt_NotFound(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
_, err = GetNotificationSentAt(db, "nonexistent")
|
||||
if err != sql.ErrNoRows {
|
||||
t.Errorf("expected sql.ErrNoRows, got %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestGetUnnotifiedReleases_AllUnnotified verifies all releases returned when no notifications sent.
|
||||
func TestGetUnnotifiedReleases_AllUnnotified(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
releases := []ExternalRelease{
|
||||
{RGID: "rg1", ArtistID: "artist-1", Title: "Album 1", Type: "album", ReleaseDate: "2024-01-01"},
|
||||
{RGID: "rg2", ArtistID: "artist-1", Title: "Album 2", Type: "album", ReleaseDate: "2024-06-01"},
|
||||
{RGID: "rg3", ArtistID: "artist-2", Title: "Single 1", Type: "single", ReleaseDate: "2024-03-01"},
|
||||
}
|
||||
|
||||
for _, r := range releases {
|
||||
if err := SaveExternalRelease(db, &r); err != nil {
|
||||
t.Fatalf("SaveExternalRelease(%s) error: %v", r.RGID, err)
|
||||
}
|
||||
}
|
||||
|
||||
results, err := GetUnnotifiedReleases(db)
|
||||
if err != nil {
|
||||
t.Fatalf("GetUnnotifiedReleases() error: %v", err)
|
||||
}
|
||||
if len(results) != 3 {
|
||||
t.Fatalf("expected 3 unnotified releases, got %d", len(results))
|
||||
}
|
||||
}
|
||||
|
||||
// TestGetUnnotifiedReleases_SomeNotified verifies only unnotified releases are returned.
|
||||
func TestGetUnnotifiedReleases_SomeNotified(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
releases := []ExternalRelease{
|
||||
{RGID: "rg1", ArtistID: "artist-1", Title: "Album 1", Type: "album", ReleaseDate: "2024-01-01"},
|
||||
{RGID: "rg2", ArtistID: "artist-1", Title: "Album 2", Type: "album", ReleaseDate: "2024-06-01"},
|
||||
{RGID: "rg3", ArtistID: "artist-2", Title: "Single 1", Type: "single", ReleaseDate: "2024-03-01"},
|
||||
}
|
||||
|
||||
for _, r := range releases {
|
||||
if err := SaveExternalRelease(db, &r); err != nil {
|
||||
t.Fatalf("SaveExternalRelease(%s) error: %v", r.RGID, err)
|
||||
}
|
||||
}
|
||||
|
||||
// Mark rg1 and rg3 as notified.
|
||||
if err := MarkNotificationSent(db, "rg1"); err != nil {
|
||||
t.Fatalf("MarkNotificationSent(rg1) error: %v", err)
|
||||
}
|
||||
if err := MarkNotificationSent(db, "rg3"); err != nil {
|
||||
t.Fatalf("MarkNotificationSent(rg3) error: %v", err)
|
||||
}
|
||||
|
||||
results, err := GetUnnotifiedReleases(db)
|
||||
if err != nil {
|
||||
t.Fatalf("GetUnnotifiedReleases() error: %v", err)
|
||||
}
|
||||
if len(results) != 1 {
|
||||
t.Fatalf("expected 1 unnotified release, got %d", len(results))
|
||||
}
|
||||
if results[0].RGID != "rg2" {
|
||||
t.Errorf("expected unnotified release rg2, got %s", results[0].RGID)
|
||||
}
|
||||
if results[0].Title != "Album 2" {
|
||||
t.Errorf("expected Title 'Album 2', got %q", results[0].Title)
|
||||
}
|
||||
}
|
||||
|
||||
// TestGetUnnotifiedReleases_AllNotified verifies empty result when all releases are notified.
|
||||
func TestGetUnnotifiedReleases_AllNotified(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
releases := []ExternalRelease{
|
||||
{RGID: "rg1", ArtistID: "artist-1", Title: "Album 1"},
|
||||
{RGID: "rg2", ArtistID: "artist-1", Title: "Album 2"},
|
||||
}
|
||||
|
||||
for _, r := range releases {
|
||||
if err := SaveExternalRelease(db, &r); err != nil {
|
||||
t.Fatalf("SaveExternalRelease(%s) error: %v", r.RGID, err)
|
||||
}
|
||||
}
|
||||
|
||||
// Mark all as notified.
|
||||
for _, r := range releases {
|
||||
if err := MarkNotificationSent(db, r.RGID); err != nil {
|
||||
t.Fatalf("MarkNotificationSent(%s) error: %v", r.RGID, err)
|
||||
}
|
||||
}
|
||||
|
||||
results, err := GetUnnotifiedReleases(db)
|
||||
if err != nil {
|
||||
t.Fatalf("GetUnnotifiedReleases() error: %v", err)
|
||||
}
|
||||
if len(results) != 0 {
|
||||
t.Errorf("expected 0 unnotified releases, got %d", len(results))
|
||||
}
|
||||
}
|
||||
|
||||
// TestGetUnnotifiedReleases_NoReleases verifies empty result when no releases exist.
|
||||
func TestGetUnnotifiedReleases_NoReleases(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
results, err := GetUnnotifiedReleases(db)
|
||||
if err != nil {
|
||||
t.Fatalf("GetUnnotifiedReleases() error: %v", err)
|
||||
}
|
||||
if len(results) != 0 {
|
||||
t.Errorf("expected 0 unnotified releases, got %d", len(results))
|
||||
}
|
||||
}
|
||||
|
||||
// TestMarkNotificationSent_MultipleReleases verifies marking multiple different RGIDs.
|
||||
func TestMarkNotificationSent_MultipleReleases(t *testing.T) {
|
||||
db, err := New(":memory:")
|
||||
if err != nil {
|
||||
t.Fatalf("New() error: %v", err)
|
||||
}
|
||||
defer db.Close()
|
||||
|
||||
rgids := []string{"rg1", "rg2", "rg3"}
|
||||
for _, rgid := range rgids {
|
||||
if err := MarkNotificationSent(db, rgid); err != nil {
|
||||
t.Fatalf("MarkNotificationSent(%s) error: %v", rgid, err)
|
||||
}
|
||||
}
|
||||
|
||||
for _, rgid := range rgids {
|
||||
sent, err := IsNotificationSent(db, rgid)
|
||||
if err != nil {
|
||||
t.Fatalf("IsNotificationSent(%s) error: %v", rgid, err)
|
||||
}
|
||||
if !sent {
|
||||
t.Errorf("expected IsNotificationSent(%s) to return true", rgid)
|
||||
}
|
||||
}
|
||||
|
||||
// Verify count.
|
||||
var count int
|
||||
err = db.Conn().QueryRow("SELECT COUNT(*) FROM notifications_sent").Scan(&count)
|
||||
if err != nil {
|
||||
t.Fatalf("count query error: %v", err)
|
||||
}
|
||||
if count != 3 {
|
||||
t.Errorf("expected 3 notification rows, got %d", count)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user