fix: address code review findings
- notifier: show artist display names (not internal IDs) in digest; resolve names from artist_settings and fall back to ID when unavailable - notifier: skip sending an empty digest to avoid daily spam - config: require telegram token/chat_id when enabled - web: warn loudly when auth is disabled on a non-loopback bind; add HTTP server timeouts - web: treat SetReleaseIgnored "release not found" as benign redirect (0 rows) - musicbrainz: reject low-score/name-mismatched MBID resolutions instead of silently caching the wrong artist - database: remove dead duplicate err check; harden DSN param appending - musicbrainz: check rows.Err() after iterating existing releases
This commit is contained in:
@@ -114,6 +114,10 @@ func SyncArtistDiscography(
|
||||
}
|
||||
ignoredMap[rgid] = ignored
|
||||
}
|
||||
if err := rows.Err(); err != nil {
|
||||
rows.Close()
|
||||
return nil, fmt.Errorf("sync artist discography: iterate existing releases: %w", err)
|
||||
}
|
||||
rows.Close()
|
||||
|
||||
// Build the set of RGIDs present in this sync so we can drop only the rows
|
||||
|
||||
Reference in New Issue
Block a user