fix: address code review findings (consolidate slice helpers, correct bootleg comment)

internal/musicbrainz/api.go

@@ -94,10 +94,9 @@ func FilterReleaseGroups(groups []ReleaseGroup, opts FilterOptions) []ReleaseGro
 	return filtered
 }
 
-// hasSecondaryType reports whether any of the release group's secondary types
-// matches one of the provided values.
-func hasSecondaryType(rg ReleaseGroup, wanted ...string) bool {
-	for _, s := range rg.SecondaryTypes {
+// hasSliceType reports whether the slice contains any of the wanted values.
+func hasSliceType(types []string, wanted ...string) bool {
+	for _, s := range types {
 		for _, w := range wanted {
 			if s == w {
 				return true
@@ -107,6 +106,12 @@ func hasSecondaryType(rg ReleaseGroup, wanted ...string) bool {
 	return false
 }
 
+// hasSecondaryType reports whether any of the release group's secondary types
+// matches one of the provided values.
+func hasSecondaryType(rg ReleaseGroup, wanted ...string) bool {
+	return hasSliceType(rg.SecondaryTypes, wanted...)
+}
+
 // IsTypeIncluded returns true if the given primary type is in the base
 // included set (Album/Single/EP).
 func IsTypeIncluded(releaseType string) bool {

internal/musicbrainz/sync.go

@@ -152,18 +152,6 @@ func SyncArtistDiscography(
 	return releases, nil
 }
 
-// hasSliceType reports whether the slice contains the wanted value. It mirrors
-// hasSecondaryType in api.go but operates on the persisted []string form read
-// back from external_releases (cache-hit path).
-func hasSliceType(types []string, wanted string) bool {
-	for _, t := range types {
-		if t == wanted {
-			return true
-		}
-	}
-	return false
-}
-
 // getArtistFilterOptions reads per-artist type filtering preferences.
 // Defaults to no filtering if artist_settings row doesn't exist.
 // artistID is the Navidrome artist ID (artist_settings.id), not the MusicBrainz ID.