- Fix notifications_sent schema: change to composite PK (rgid, sent_at) per plan spec, remove FK constraint - Change MarkNotificationSent from INSERT OR REPLACE to INSERT (composite PK semantics) - Update test: replace idempotent test with duplicate-second and different-time tests - Refactor UpdateArtistSettings to use switch-based column validation instead of fmt.Sprintf with map lookup - Remove generated coverage.out from repo, add to .gitignore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
117 lines
3.3 KiB
Go
117 lines
3.3 KiB
Go
package database
|
|
|
|
import (
|
|
"fmt"
|
|
)
|
|
|
|
// GetArtistSettings retrieves an artist_settings row by ID.
|
|
// Returns sql.ErrNoRows if the artist is not found.
|
|
func GetArtistSettings(db *DB, id string) (*ArtistSettings, error) {
|
|
var s ArtistSettings
|
|
err := db.Conn().QueryRow(
|
|
"SELECT id, name, ignore_singles, ignore_compilations, monitored FROM artist_settings WHERE id = ?",
|
|
id,
|
|
).Scan(&s.ID, &s.Name, &s.IgnoreSingles, &s.IgnoreCompilations, &s.Monitored)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &s, nil
|
|
}
|
|
|
|
// SaveArtistSettings inserts or replaces an artist_settings row.
|
|
func SaveArtistSettings(db *DB, settings *ArtistSettings) error {
|
|
_, err := db.Conn().Exec(
|
|
"INSERT OR REPLACE INTO artist_settings (id, name, ignore_singles, ignore_compilations, monitored) VALUES (?, ?, ?, ?, ?)",
|
|
settings.ID, settings.Name, settings.IgnoreSingles, settings.IgnoreCompilations, settings.Monitored,
|
|
)
|
|
if err != nil {
|
|
return fmt.Errorf("save artist settings: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetAllArtistSettings returns all rows from artist_settings.
|
|
func GetAllArtistSettings(db *DB) ([]ArtistSettings, error) {
|
|
rows, err := db.Conn().Query(
|
|
"SELECT id, name, ignore_singles, ignore_compilations, monitored FROM artist_settings",
|
|
)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("query all artist settings: %w", err)
|
|
}
|
|
defer rows.Close()
|
|
|
|
var results []ArtistSettings
|
|
for rows.Next() {
|
|
var s ArtistSettings
|
|
if err := rows.Scan(&s.ID, &s.Name, &s.IgnoreSingles, &s.IgnoreCompilations, &s.Monitored); err != nil {
|
|
return nil, fmt.Errorf("scan artist settings: %w", err)
|
|
}
|
|
results = append(results, s)
|
|
}
|
|
if err := rows.Err(); err != nil {
|
|
return nil, fmt.Errorf("iterate artist settings: %w", err)
|
|
}
|
|
return results, nil
|
|
}
|
|
|
|
// UpdateArtistSettings updates specific fields of an artist_settings row by ID.
|
|
// The updates map keys must match column names: "name", "ignore_singles", "ignore_compilations", "monitored".
|
|
func UpdateArtistSettings(db *DB, id string, updates map[string]interface{}) error {
|
|
if len(updates) == 0 {
|
|
return fmt.Errorf("no updates provided")
|
|
}
|
|
|
|
// Build the query using a fixed set of allowed columns to avoid dynamic SQL.
|
|
const baseQuery = "UPDATE artist_settings SET"
|
|
|
|
var args []interface{}
|
|
setClause := ""
|
|
for col, val := range updates {
|
|
switch col {
|
|
case "name":
|
|
if setClause != "" {
|
|
setClause += ", "
|
|
}
|
|
setClause += "name = ?"
|
|
args = append(args, val)
|
|
case "ignore_singles":
|
|
if setClause != "" {
|
|
setClause += ", "
|
|
}
|
|
setClause += "ignore_singles = ?"
|
|
args = append(args, val)
|
|
case "ignore_compilations":
|
|
if setClause != "" {
|
|
setClause += ", "
|
|
}
|
|
setClause += "ignore_compilations = ?"
|
|
args = append(args, val)
|
|
case "monitored":
|
|
if setClause != "" {
|
|
setClause += ", "
|
|
}
|
|
setClause += "monitored = ?"
|
|
args = append(args, val)
|
|
default:
|
|
return fmt.Errorf("unknown column: %s", col)
|
|
}
|
|
}
|
|
|
|
args = append(args, id)
|
|
query := fmt.Sprintf("%s %s WHERE id = ?", baseQuery, setClause)
|
|
result, err := db.Conn().Exec(query, args...)
|
|
if err != nil {
|
|
return fmt.Errorf("update artist settings: %w", err)
|
|
}
|
|
|
|
rowsAffected, err := result.RowsAffected()
|
|
if err != nil {
|
|
return fmt.Errorf("rows affected: %w", err)
|
|
}
|
|
if rowsAffected == 0 {
|
|
return fmt.Errorf("artist not found: %s", id)
|
|
}
|
|
|
|
return nil
|
|
}
|