Mrixs/trip-planner
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address code review findings

Browse Source
This commit is contained in:
Vladimir Zagainov
2026-08-18 14:25:34 +03:00
parent 48650d96cf
commit 0d603ad15f
6 changed files with 56 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
cmd/cron/station_status.go
View File

@@ -131,12 +131,17 @@ func (sm *StationMonitor) updateStationStatus(ctx context.Context, tripCount int
zeroSinceData, err := sm.Cache.Get(ctx, zeroSinceKey)
var zeroSince time.Time
if err == nil && zeroSinceData != nil {
var zeroSinceUnix int64
_, parseErr := fmt.Sscanf(string(zeroSinceData), "%d", &zeroSinceUnix)
if parseErr == nil {
zeroSince = time.Unix(zeroSinceUnix, 0)
} else {
// Handle "0" marker for time.Time{} (no zero-since)
if string(zeroSinceData) == "0" {
zeroSince = time.Time{}
} else {
var zeroSinceUnix int64
_, parseErr := fmt.Sscanf(string(zeroSinceData), "%d", &zeroSinceUnix)
if parseErr == nil {
zeroSince = time.Unix(zeroSinceUnix, 0)
} else {
zeroSince = time.Time{}
}
}
}
@@ -184,7 +189,12 @@ func (sm *StationMonitor) updateStationStatus(ctx context.Context, tripCount int
}
// Write updated zero-since timestamp to cache with 24h TTL
if err := sm.Cache.Set(ctx, zeroSinceKey, []byte(fmt.Sprintf("%d", zeroSince.Unix())), 24*time.Hour); err != nil {
// Use "0" marker for time.Time{} to indicate no zero-since
zeroSinceStr := "0"
if !zeroSince.IsZero() {
zeroSinceStr = fmt.Sprintf("%d", zeroSince.Unix())
}
if err := sm.Cache.Set(ctx, zeroSinceKey, []byte(zeroSinceStr), 24*time.Hour); err != nil {
return newStatus, fmt.Errorf("cache set zero since: %w", err)
}