fix: address code review findings
This commit is contained in:
@@ -170,7 +170,6 @@ func (c *Client) Do(ctx context.Context, method, path string, query map[string]s
|
||||
}
|
||||
}
|
||||
|
||||
c.circuitBreaker.recordFailure() // final failure
|
||||
c.metrics.RecordCircuitBreakerTrip()
|
||||
return nil, err
|
||||
}
|
||||
@@ -299,7 +298,7 @@ func buildURL(path string, query map[string]string) string {
|
||||
return u
|
||||
}
|
||||
|
||||
// --- Token Bucket Rate Limitter ---
|
||||
// --- Token Bucket Rate Limiter ---
|
||||
|
||||
func newTokenBucket(capacity, perSeconds int) *tokenBucket {
|
||||
return &tokenBucket{
|
||||
@@ -322,7 +321,7 @@ func (tb *tokenBucket) acquire() error {
|
||||
return nil
|
||||
}
|
||||
|
||||
return fmt.Errorf("rate limit: rate exceeded (%.1f TPS configured)", float64(tb.refillPerSec)/float64(time.Second))
|
||||
return fmt.Errorf("rate limit: rate exceeded (%.1f TPS configured)", float64(tb.refillPerSec))
|
||||
}
|
||||
|
||||
func (tb *tokenBucket) refill(now time.Time) {
|
||||
|
||||
Reference in New Issue
Block a user