fix: address code review findings

This commit is contained in:
2026-08-18 13:57:30 +03:00
parent 2cf9e20608
commit 48650d96cf
4 changed files with 31 additions and 11 deletions

View File

@@ -1,7 +1,7 @@
package main
import (
"crypto/hmac"
"crypto/subtle"
"encoding/json"
"fmt"
"net/http"
@@ -435,7 +435,7 @@ func adminAuth(hc *HandlerContext, w http.ResponseWriter, r *http.Request) bool
return false
}
providedAPIKey := r.Header.Get("X-Admin-Api-Key")
if !hmac.Equal([]byte(providedAPIKey), []byte(expectedAPIKey)) {
if subtle.ConstantTimeCompare([]byte(providedAPIKey), []byte(expectedAPIKey)) != 1 {
http.Error(w, "unauthorized", http.StatusUnauthorized)
return false
}