Mrixs/trip-planner
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address code review findings

Browse Source
This commit is contained in:
Vladimir Zagainov
2026-08-19 12:48:30 +03:00
parent b14682f424
commit 4a7be531ed
4 changed files with 33 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
internal/routing/graph.go
View File

@@ -557,21 +557,22 @@ func (g *Graph) FindRoute(originID, destID string, opts SearchOptions, closedSta
newDurationWithMCT := newDuration + transferTime
// Check if we've visited this node with fewer transfers
visKey := nextNode.ID
if existingTransfers, ok := visited[visKey]; ok {
if current.transfers+1 > existingTransfers {
// Already visited this node with fewer transfers, skip
continue
}
}
visited[visKey] = current.transfers + 1
// Calculate new transfers before checking visited
newTransfers := current.transfers
if edge.IsTransfer {
newTransfers++
}
// Check if we've visited this node with fewer transfers
visKey := nextNode.ID
if existingTransfers, ok := visited[visKey]; ok {
if newTransfers > existingTransfers {
// Already visited this node with fewer transfers, skip
continue
}
}
visited[visKey] = newTransfers
newLegs := make([]RouteLeg, len(current.itinerary.Legs)+1)
copy(newLegs, current.itinerary.Legs)
@@ -733,21 +734,22 @@ func (g *Graph) FindRoute(originID, destID string, opts SearchOptions, closedSta
newDurationWithMCT := newDuration + transferTime
// Check if we've visited this node with fewer transfers
visKey := nextNode.ID
if existingTransfers, ok := visited[visKey]; ok {
if current.transfers+1 > existingTransfers {
// Already visited this node with fewer transfers, skip
continue
}
}
visited[visKey] = current.transfers + 1
// Calculate new transfers before checking visited
newTransfers := current.transfers
if edge.IsTransfer {
newTransfers++
}
// Check if we've visited this node with fewer transfers
visKey := nextNode.ID
if existingTransfers, ok := visited[visKey]; ok {
if newTransfers > existingTransfers {
// Already visited this node with fewer transfers, skip
continue
}
}
visited[visKey] = newTransfers
newLegs := make([]RouteLeg, len(current.itinerary.Legs)+1)
copy(newLegs, current.itinerary.Legs)