fix: address code review findings

This commit is contained in:
2026-08-17 21:50:37 +03:00
parent 9c402c0086
commit 777fda95a3
6 changed files with 76 additions and 23 deletions

View File

@@ -222,17 +222,16 @@ func (c *CacheAside) GetSearch(ctx context.Context, key *CacheKey, fetch func()
// Try cache first
data, err := c.store.Get(ctx, key)
if err == nil && data != nil {
if err != nil {
return nil, err
}
if data != nil {
c.metrics.RecordCacheHit("search") // cache hit
return data, nil
}
// Cache miss: fetch from backend
if errors.Is(err, redis.Nil) {
c.metrics.RecordCacheMiss("search") // record search cache miss
} else if err != nil {
return nil, err
}
c.metrics.RecordCacheMiss("search") // record search cache miss
// Fetch from backend
data, err = fetch()