Mrixs/trip-planner
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address code review findings

Browse Source
This commit is contained in:
Vladimir Zagainov
2026-08-17 21:19:36 +03:00
parent 82757665e9
commit 9c402c0086
5 changed files with 49 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/api/handlers_test.go
View File

@@ -19,9 +19,8 @@ import (
func flushRedisForTest(t *testing.T, client *redis.Client) {
// Clear preference-related keys from Redis to ensure test isolation
// The keyString sanitization prepends "unknown:" and replaces ":" with "_colon_"
// Actual keys look like: "unknown:prefs_colon_saved_city_colon_testuser1"
keys, err := client.Keys(context.Background(), "unknown:prefs*").Result()
// Actual keys look like: "prefs:saved_city:testuser1" and "prefs:search_history:testuser1"
keys, err := client.Keys(context.Background(), "prefs:saved_city:*").Result()
if err != nil {
t.Logf("warning: could not flush preference keys: %v", err)
return
@@ -32,7 +31,7 @@ func flushRedisForTest(t *testing.T, client *redis.Client) {
}
}
// Also delete search_history keys
keys2, err := client.Keys(context.Background(), "unknown:search_history*").Result()
keys2, err := client.Keys(context.Background(), "prefs:search_history:*").Result()
if err != nil {
t.Logf("warning: could not flush search history keys: %v", err)
return
@@ -765,7 +764,7 @@ func TestUserPreferences(t *testing.T) {
flushRedisForTest(t, h.Redis)
// Add a saved city
addReq := httptest.NewRequest("POST", "/v1/preferences/saved-cities?user_id=testuser2", strings.NewReader(`{"city_code":"c1","name":"Moscow"}`,))
addReq := httptest.NewRequest("POST", "/v1/preferences/saved-cities?user_id=testuser2", strings.NewReader(`{"city_code":"c1","name":"Moscow"}`))
addReq.Header.Set("Content-Type", "application/json")
addRR := httptest.NewRecorder()
AddSavedCity(h, addRR, addReq)