Mrixs/trip-planner
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address code review findings

Browse Source
This commit is contained in:
Vladimir Zagainov
2026-08-17 21:19:36 +03:00
parent 82757665e9
commit 9c402c0086
5 changed files with 49 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
cmd/cron/station_status.go
View File

@@ -76,7 +76,7 @@ func checkStationSchedule(ctx context.Context, yc *yandex.Client, stationID stri
// The Yandex Do method handles the API request with rate limiting,
// circuit breaking, and retry. It returns a Response with the
// schedule data including interval segments.
resp, err := yc.Do(ctx, "schedule", "/station/"+stationID, map[string]string{
resp, err := yc.Do(ctx, "GET", "/station/"+stationID, map[string]string{
"date": time.Now().Format("2006-01-02"),
})
if err != nil {
@@ -131,8 +131,11 @@ func (sm *StationMonitor) updateStationStatus(ctx context.Context, tripCount int
zeroSinceData, err := sm.Cache.Get(ctx, zeroSinceKey)
var zeroSince time.Time
if err == nil && zeroSinceData != nil {
_, err := fmt.Sscanf(string(zeroSinceData), "%d", (&zeroSince).Unix())
if err != nil {
var zeroSinceUnix int64
_, err := fmt.Sscanf(string(zeroSinceData), "%d", &zeroSinceUnix)
if err == nil {
zeroSince = time.Unix(zeroSinceUnix, 0)
} else {
zeroSince = time.Time{}
}
}
@@ -141,8 +144,11 @@ func (sm *StationMonitor) updateStationStatus(ctx context.Context, tripCount int
lastSeenFlightData, err := sm.Cache.Get(ctx, lastSeenFlightKey)
var lastSeenFlight time.Time
if err == nil && lastSeenFlightData != nil {
_, err := fmt.Sscanf(string(lastSeenFlightData), "%d", (&lastSeenFlight).Unix())
if err != nil {
var lastSeenFlightUnix int64
_, err := fmt.Sscanf(string(lastSeenFlightData), "%d", &lastSeenFlightUnix)
if err == nil {
lastSeenFlight = time.Unix(lastSeenFlightUnix, 0)
} else {
lastSeenFlight = time.Time{}
}
}