Vladimir Zagainov
8a5b58a817
- Fix artist-ID namespace mismatch in MusicBrainz provider: SyncArtistDiscography now stores the canonical Navidrome artist ID (artist_settings.id) as external_releases.artist_id instead of the MusicBrainz MBID. Previously the MBID was stored, which violated the FK to artist_settings and broke the scanner join (local_albums.artist_id is the Navidrome ID), causing every external release to be falsely reported as missing and the sync insert to fail at runtime. getArtistFilterOptions now also resolves by the Navidrome ID. - Resolve threshold in FindMissingReleases so the exported primitive honors the same zero-means-default contract as ScanArtist/ScanAll. - Remove dead maxLen==0 guard in scanner.Similarity. - Inline trivial buildPath helper; drop unused url import in client.go. - Replace hand-rolled itoa with strconv.Itoa in tests. - Rewrite SyncArtistDiscography tests to seed artist_settings with the Navidrome ID (tests previously seeded the MBID to mask the FK mismatch). - Fix TestFuzzySmoke to exercise the real dependency (fuzzy.LevenshteinDistance / scanner.Similarity) instead of an unused API. - Fix TestAppRun_ScanLogsMissingReleases to run the scan against a live context and assert the missing release is found. - Document cached_at column in Specification.md and note startup scan / required musicbrainz.user_agent in README. - Stop tracking .serena/ tooling config; add it to .gitignore.
37 lines
1.4 KiB
Go
37 lines
1.4 KiB
Go
package main
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/lithammer/fuzzysearch/fuzzy"
|
|
|
|
"naviwatcher/internal/scanner"
|
|
)
|
|
|
|
// TestFuzzySmoke verifies the fuzzysearch dependency and the Levenshtein-based
|
|
// similarity primitive that the scanner engine actually uses (scanner.Similarity
|
|
// delegates to fuzzy.LevenshteinDistance). This guards against the library
|
|
// changing the distance semantics the engine relies on.
|
|
func TestFuzzySmoke(t *testing.T) {
|
|
// Identical strings: zero edit distance.
|
|
if d := fuzzy.LevenshteinDistance("the wall", "the wall"); d != 0 {
|
|
t.Errorf("expected LevenshteinDistance of identical strings to be 0, got %d", d)
|
|
}
|
|
|
|
// A small edit (remaster suffix) is closer than a wholly different title.
|
|
near := fuzzy.LevenshteinDistance("the wall", "the wall remastered")
|
|
far := fuzzy.LevenshteinDistance("the wall", "completely different album")
|
|
if near >= far {
|
|
t.Errorf("expected near match distance (%d) < far match distance (%d)", near, far)
|
|
}
|
|
|
|
// The scanner's similarity score should report the near match as more
|
|
// similar than the far one, and the identical pair as a perfect match.
|
|
if s := scanner.Similarity("the wall", "the wall"); s != 1.0 {
|
|
t.Errorf("expected Similarity of identical strings to be 1.0, got %f", s)
|
|
}
|
|
if scanner.Similarity("the wall", "the wall remastered") <= scanner.Similarity("the wall", "completely different album") {
|
|
t.Error("expected near match to score higher than far match")
|
|
}
|
|
}
|